On Wed, Nov 9, 2022 at 3:45 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Sun, Nov 06, 2022 at 10:57:53PM +0800, Dawei Li wrote: > > For bus-based driver, device removal is implemented as: > > 1 device_remove()-> > > 2 bus->remove()-> > > 3 driver->remove() > > > > Driver core needs _no_ inform from callee(bus driver) about the > > result of remove callback. In that case, > > commit <fc7a6209d571> ("bus: Make remove callback return void") Also please read Submitting Patches on how to provide a commit reference in the message body. > > forces struct bus_type::remove() be void-returned. > > > > Now we have the situation that both 1 & 2 of calling chain are > > void-returned, so it does _not_ make much sense for 3(driver->remove) > > to return non-void to its caller. > > > > So the basic idea behind this change is making remove() callback of > > any bus-based driver to be void-returned. > > > > This change itself, is for device drivers based on acpi-bus. -- With Best Regards, Andy Shevchenko