On Mon, Nov 7, 2022 at 10:28 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Mon, Nov 07, 2022 at 09:03:06PM +0100, Rafael J. Wysocki wrote: > > ... > > > +static inline void acpi_rtc_event_cleanup(void) > > +{ > > + if (!acpi_disabled) > > Btw, other functions look like using > > if (acpi_disabled) > return; > > pattern. Maybe here the same for the sake of consistency? > > > + acpi_remove_fixed_event_handler(ACPI_EVENT_RTC, rtc_handler); > > +} > Well, it is more lines of code, but whatever.