On Tue, Oct 04, 2022 at 10:24:13AM +0200, Greg Kroah-Hartman wrote: > On Tue, Oct 04, 2022 at 11:14:14AM +0300, Andy Shevchenko wrote: > > On Tue, Oct 04, 2022 at 09:55:21AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Oct 03, 2022 at 08:08:58PM +0000, Sakari Ailus wrote: > > > > On Mon, Oct 03, 2022 at 06:17:17PM +0200, Greg Kroah-Hartman wrote: ... > > > > #define kobj_to_dev(kobj) \ > > > > (_Generic((kobj), \ > > > > const struct kobject *: __kobj_to_dev_const, \ > > > > struct kobject *: __kobj_to_dev)(kobj)) > > > > > > Ah, doh! I had the (kobj) part in the wrong place, thanks for that > > > fix... > > > > > > Ok, this looks better, let me see how well the build breaks with some of > > > these changes > > > > I believe I can rewrite my patch like this and then it will be much nicer since > > we may constify all the rest without calling __dev_fwnode_const() directly. > > > > Are you agree? > > Yes, I think this is a much better option, try it and see. Below is the > patch I'm running through my build systems at the moment, feel free to > copy the style for your change as well. Yep, thanks for sharing! -- With Best Regards, Andy Shevchenko
