On Thu, Sep 29, 2022 at 1:18 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > > On Thu, Sep 29, 2022 at 6:19 PM Raul E Rangel <rrangel@xxxxxxxxxxxx> wrote: > > > > ACPI IRQ/Interrupt resources contain a bit that describes if the > > interrupt should wake the system. This change exposes that bit via > > a new IORESOURCE_IRQ_WAKECAPABLE flag. Drivers should check this flag > > I would call this IORESOURCE_IRQ_WAKE which is (a) simpler and easier > to read and (b) it sort of matches the "wakeirq" naming convention. It was Dmitry who originally suggested the name. I personally like the CAPABLE in the name. It makes it clear that it's capable of acting as a wake source, not to be confused with being enabled as a wake source. > > This is not a big deal if you insist on this name and for a good > reason, but just something I would do differently. > > The patch LGTM otherwise. >
