On Wed, Sep 21, 2022 at 5:43 PM Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > On Tue, Sep 20, 2022 at 05:45:00PM +0800, Huisong Li wrote: > > A error, "Client can't run the TX ticker", is printed even if PCC command > > executed successfully. This root cause is that PCC handler calls > > 'mbox_client_txdone()' which depands on the client can received 'ACK' > > packet. But PCC handler detects whether the command is complete through > > the Tx ACK interrupt. So this patch fix it. > > > > Thanks for fixing this. Someone mentioned about the error and it was in > my TODO list. > > I would prefer to reword the subject and commit message as below: > " > ACPI: PCC: Fix Tx acknowledge in the PCC address space handler > > Currently, mbox_client_txdone() is called from the PCC address space > handler and that expects the user the Tx state machine to be controlled > by the client which is not the case and the below warning is thrown: > > | PCCT: Client can't run the TX ticker > > Let the controller run the state machine and the end of Tx can be > acknowledge by calling mbox_chan_txdone() instead. > " > > With that: > > Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx> Applied as 6.1 material along with the [1/2]. I used the above text in quotes as the subject and changelog instead of the original pieces. Thanks!
