Hi Huacai, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on soc/for-next] [also build test WARNING on linus/master v6.0-rc5 next-20220916] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/LoongArch-Add-ACPI-based-generic-laptop-driver/20220917-145525 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: loongarch-randconfig-r016-20220916 (https://download.01.org/0day-ci/archive/20220917/202209172111.ajQbMqwZ-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/3ebe2785d58311650d0f98635c9817e0c2c12f91 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Huacai-Chen/LoongArch-Add-ACPI-based-generic-laptop-driver/20220917-145525 git checkout 3ebe2785d58311650d0f98635c9817e0c2c12f91 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/platform/loongarch/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/platform/loongarch/generic-laptop.c:409:5: warning: no previous prototype for 'loongson_laptop_turn_on_backlight' [-Wmissing-prototypes] 409 | int loongson_laptop_turn_on_backlight(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/platform/loongarch/generic-laptop.c:425:5: warning: no previous prototype for 'loongson_laptop_turn_off_backlight' [-Wmissing-prototypes] 425 | int loongson_laptop_turn_off_backlight(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/loongson_laptop_turn_on_backlight +409 drivers/platform/loongarch/generic-laptop.c 408 > 409 int loongson_laptop_turn_on_backlight(void) 410 { 411 int status; 412 union acpi_object arg0 = { ACPI_TYPE_INTEGER }; 413 struct acpi_object_list args = { 1, &arg0 }; 414 415 arg0.integer.value = 1; 416 status = acpi_evaluate_object(NULL, "\\BLSW", &args, NULL); 417 if (ACPI_FAILURE(status)) { 418 pr_info("Loongson lvds error: 0x%x\n", status); 419 return -ENODEV; 420 } 421 422 return 0; 423 } 424 > 425 int loongson_laptop_turn_off_backlight(void) 426 { 427 int status; 428 union acpi_object arg0 = { ACPI_TYPE_INTEGER }; 429 struct acpi_object_list args = { 1, &arg0 }; 430 431 arg0.integer.value = 0; 432 status = acpi_evaluate_object(NULL, "\\BLSW", &args, NULL); 433 if (ACPI_FAILURE(status)) { 434 pr_info("Loongson lvds error: 0x%x\n", status); 435 return -ENODEV; 436 } 437 438 return 0; 439 } 440 -- 0-DAY CI Kernel Test Service https://01.org/lkp
