On Sun, Sep 11, 2022 at 05:45:35PM +0800, Gaosheng Cui wrote: > pnpid32_to_pnpid() has been removed since > commit 25eb846189d2 ("PNP: add pnp_eisa_id_to_string()"), > so remove it. Woof, I guess I messed that up, sorry :( I would word the commit log as: All uses of pnpid32_to_pnpid() were removed by 25eb846189d2 ("PNP: add pnp_eisa_id_to_string()"), so remove the declaration, too. Regardless, Reviewed-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Signed-off-by: Gaosheng Cui <cuigaosheng1@xxxxxxxxxx> > --- > drivers/pnp/pnpbios/pnpbios.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pnp/pnpbios/pnpbios.h b/drivers/pnp/pnpbios/pnpbios.h > index 2ce739ff9c1a..f3302006842e 100644 > --- a/drivers/pnp/pnpbios/pnpbios.h > +++ b/drivers/pnp/pnpbios/pnpbios.h > @@ -153,7 +153,6 @@ extern int pnpbios_dont_use_current_config; > extern int pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node * node); > extern int pnpbios_read_resources_from_node(struct pnp_dev *dev, struct pnp_bios_node *node); > extern int pnpbios_write_resources_to_node(struct pnp_dev *dev, struct pnp_bios_node *node); > -extern void pnpid32_to_pnpid(u32 id, char *str); > > extern void pnpbios_print_status(const char * module, u16 status); > extern void pnpbios_calls_init(union pnp_bios_install_struct * header); > -- > 2.25.1 >