Am 13.09.22 um 18:08 schrieb Limonciello, Mario:
[Public]
-----Original Message-----
From: Armin Wolf <W_Armin@xxxxxx>
Sent: Tuesday, September 13, 2022 09:41
To: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>; hdegoede@xxxxxxxxxx;
markgross@xxxxxxxxxx
Cc: rafael@xxxxxxxxxx; lenb@xxxxxxxxxx; hmh@xxxxxxxxxx;
matan@xxxxxxxxxxx; corentin.chary@xxxxxxxxx; jeremy@xxxxxxxxxxxx;
productdev@xxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 5/5] platform/x86: dell: Add new dell-wmi-ddv driver
Am 12.09.22 um 23:56 schrieb Randy Dunlap:
Hi--
On 9/12/22 05:53, Armin Wolf wrote:
diff --git a/drivers/platform/x86/dell/Kconfig
b/drivers/platform/x86/dell/Kconfig
index 25421e061c47..209e63e347e2 100644
--- a/drivers/platform/x86/dell/Kconfig
+++ b/drivers/platform/x86/dell/Kconfig
@@ -189,6 +189,19 @@ config DELL_WMI_DESCRIPTOR
default n
depends on ACPI_WMI
+config DELL_WMI_DDV
+ tristate "Dell WMI sensors Support"
+ default m
You should (try to) justify default m, otherwise just
don't have a default for it.
I have chosen default m since many other Dell platform drivers are being
default m. Since this driver is not essential for normal operation,
i will drop default m then.
Actually Dell drivers directory are a bit unique in this regard. There is a special
top level boolean. I would suggest to keep it as is.
Take a look at:
menuconfig X86_PLATFORM_DRIVERS_DELL
Ok.
Armin Wolf
Armin Wolf
+ depends on ACPI_BATTERY
+ depends on ACPI_WMI
+ help
+ This option adds support for WMI-based sensors like
+ battery temperature sensors found on some Dell notebooks.
+ It also supports reading of the batteries ePPID.
+
+ To compile this drivers as a module, choose M here: the module will
+ be called dell-wmi-ddv.
