On Wednesday, August 31, 2022 1:40 AM, Jia He wrote: > Introduce a flag ghes_present to differentiate between the system ROM > really not offering GHES vs. the ghes module not running. ghes-present > is latched on ghes_probe() and never unlatched since ACPI GHES table > is static. > > Introduce a helper ghes_edac_preferred() and it is true if the > platform-check passes. I'd suggest to rephase a bit, something like: == Introduce a helper ghes_edac_preferred(), which returns true when ACPI GHES table is present and the platform-check passes on the system. ghes_present is set once in ghes_probe() since ACPI GHES table is static. == Otherwise, the patch looks good to me. Reviewed-by: Toshi Kani <toshi.kani@xxxxxxx> Toshi
