On Tue, Aug 30, 2022 at 08:11:54PM +0300, Andy Shevchenko wrote: > -#define VR_MODE_DISABLED 0 > -#define VR_MODE_AUTO BIT(0) > -#define VR_MODE_NORMAL BIT(1) > -#define VR_MODE_SWITCH BIT(2) > -#define VR_MODE_ECO (BIT(0)|BIT(1)) > +#define PMIC_REG_MASK GENMASK(11, 0) > + > +#define VR_MODE_DISABLED (0 << 0) > +#define VR_MODE_AUTO (1 << 0) > +#define VR_MODE_NORMAL (2 << 0) > +#define VR_MODE_ECO (3 << 0) > +#define VR_MODE_SWITCH (4 << 0) IMHO this one is worse than what it was. Anyway, that's just a nitpick. The other parts look good, Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>