Hi, On 8/24/22 20:49, Arvid Norlander wrote: > Toshiba Satellite Z830 needs the quirk video_disable_backlight_sysfs_if > for proper backlight control after suspend/resume cycles. > > Toshiba Portege Z830 is simply the same laptop rebranded for certain > markets (I looked through the manual to other language sections to confirm > this) and thus also needs this quirk. > > Thanks to Hans de Goede for suggesting this fix. > > Link: https://www.spinics.net/lists/platform-driver-x86/msg34394.html > Signed-off-by: Arvid Norlander <lkml@xxxxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > > --- > drivers/acpi/acpi_video.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c > index 5cbe2196176d..2a4990733cf0 100644 > --- a/drivers/acpi/acpi_video.c > +++ b/drivers/acpi/acpi_video.c > @@ -496,6 +496,22 @@ static const struct dmi_system_id video_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "SATELLITE R830"), > }, > }, > + { > + .callback = video_disable_backlight_sysfs_if, > + .ident = "Toshiba Satellite Z830", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "SATELLITE Z830"), > + }, > + }, > + { > + .callback = video_disable_backlight_sysfs_if, > + .ident = "Toshiba Portege Z830", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "PORTEGE Z830"), > + }, > + }, > /* > * Some machine's _DOD IDs don't have bit 31(Device ID Scheme) set > * but the IDs actually follow the Device ID Scheme.