On Thu, Jul 28, 2022 at 06:56:48PM +0200, Marcin Wojtas wrote: > There was a regression even for OF in v1, but after switching to > device_match_fwnode() it works indeed. Anyway patch v4 is imo useful, > I'll only reword the commit message. Do you mean patch 4 or patch v4? If patch 4, of course it's useful, but not for avoiding a regression with OF (case in which I drop all my claims made earlier about fw_find_net_device_by_node), but rather to actually get something working with actual ACPI (although perhaps not in this series, you'll need to add ACPI IDs in the mv88e6xxx driver some time later as well, maybe you could focus this series just on converting DSA to play nice with fwnodes). If you're already thinking about the v4 of this patch set, I'll respond to that in a separate email shortly.