śr., 27 lip 2022 o 19:00 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> napisał(a): > > On Wed, Jul 27, 2022 at 5:24 PM Marcin Wojtas <mw@xxxxxxxxxxxx> wrote: > > śr., 27 lip 2022 o 16:31 Vladimir Oltean <olteanv@xxxxxxxxx> napisał(a): > > > On Wed, Jul 27, 2022 at 08:43:19AM +0200, Marcin Wojtas wrote: > > ... > > > > > + dev = class_find_device(&net_class, NULL, fwnode, fwnode_find_parent_dev_match); > > > > > > This needs to maintain compatibility with DSA masters that have > > > dev->of_node but don't have dev->fwnode populated. > > > > Do you mean a situation analogous to what I addressed in: > > [net-next: PATCH v3 4/8] net: mvpp2: initialize port fwnode pointer > > ? > > > > I found indeed a couple of drivers that may require a similar change > > (e.g. dpaa2). > > > > IMO we have 2 options: > > - update these drivers > > Not Vladimir here, but my 2cents that update is best and elegant, it > can be done even before this series. > In general I agree it's desired, but I'm not sure if we can catch all cases just by reading code or rather base on regression reports later... Best regards, Marcin
