Hi, On 7/19/22 16:21, Mario Limonciello wrote: > Asus UM325UAZ has GPIO 18 programmed as both an interrupt and a wake > source, but confirmed with internal team on this design this pin is > floating and shouldn't have been programmed. This causes lots of > spurious IRQs on the system and horrendous battery life. > > Add a quirk to ignore attempts to program this pin on this system. > > Reported-and-tested-by: Pavel Krc <reg.krn@xxxxxxxx> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216208 > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > --- > drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index 375942d92d6f..2149713ea8f1 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -1586,6 +1586,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = { > .ignore_wake = "INT33FF:01@0", > }, > }, > + { > + /* > + * Interrupt storm caused from edge triggered floating pin > + * Found in BIOS UX325UAZ.300 > + * https://bugzilla.kernel.org/show_bug.cgi?id=216208 > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "ZenBook UX325UAZ_UM325UAZ"), > + }, > + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { > + .ignore_interrupt = "AMDI0030:00@18", > + }, > + }, > {} /* Terminating entry */ > }; >
