Hi Hans and Stefan,
On Tue, 21 Jun 2022 at 02:10, Stefan Seyfried
<stefan.seyfried@xxxxxxxxxxxxxx> wrote:
>
> Well, I looked into the acpi_video.c module and that one is to blame.
> By default, it assumes that both "OUTPUT_KEY_EVENTS" and
> "BRIGHTNESS_KEY_EVENTS" should be handled by this module.
> But on the CF-51, this does not happen. "Video Bus" does not generate
> any key events (I'm not sure about output, but plugging in a VGA monitor
> and enabling/disabling it with xrandr or tapping the "display" fn-f3
> hotkey does not get anything from "Video Bus" input device.
>
The "display" Fn-F3 hotkey doesn't generate any key events on mine
either. I have no external VGA monitors to test it anyway.
Apart from that, the patches work perfectly on my Let's Note CF-W5.
Cheers, Hans!
Tested-by: Kenneth Chan <kenneth.t.chan@xxxxxxxxx>
On Sat, 25 Jun 2022 at 03:49, Stefan Seyfried
<stefan.seyfried@xxxxxxxxxxxxxx> wrote:
>
> On 24.06.22 13:23, Hans de Goede wrote:
> > Hi All,
> >
> > Here is a series fixing the missing keypresses on some Panasonic Toughbook
> > models. These missing keypresses are caused by
> > commit ed83c9171829 ("platform/x86: panasonic-laptop: Resolve hotkey double
> > trigger bug"), which made the panasonic-laptop driver unconditionally drop
> > most WMI reported hotkeys.
> >
> > This series reverts that commit and then adds some more selective filtering
> > to still avoid the double key-presses on some models, while avoiding
> > completely missing keypresses on others.
> >
> > Rafael, these fixes rely on patch 1/7, which is a tweak to
> > the acpi_video_handles_brightness_key_presses() helper. Without this
> > tweak this series will cause a regression, so I would like to merge
> > the entire series through the pdx86 tree, may I have your ack for this?
> >
> > Regards,
> >
> > Hans
> >
> >
> > Hans de Goede (6):
> > ACPI: video: Change how we determine if brightness key-presses are
> > handled
> > platform/x86: panasonic-laptop: sort includes alphabetically
> > platform/x86: panasonic-laptop: revert "Resolve hotkey double trigger
> > bug"
> > platform/x86: panasonic-laptop: don't report duplicate brightness
> > key-presses
> > platform/x86: panasonic-laptop: filter out duplicate volume
> > up/down/mute keypresses
> > platform/x86: panasonic-laptop: Use acpi_video_get_backlight_type()
> >
> > Stefan Seyfried (1):
> > platform/x86: panasonic-laptop: de-obfuscate button codes
> >
> > drivers/acpi/acpi_video.c | 13 ++-
> > drivers/platform/x86/Kconfig | 2 +
> > drivers/platform/x86/panasonic-laptop.c | 112 ++++++++++++++++++------
> > 3 files changed, 91 insertions(+), 36 deletions(-)
>
> The whole series works without any manual setup on my Toughbook CF-51:
>
> Tested-by: Stefan Seyfried <seife+kernel@xxxxxxxxxxxxxx>
>
> Thanks again!
>
> Stefan
> --
> Stefan Seyfried
>
> "For a successful technology, reality must take precedence over
> public relations, for nature cannot be fooled." -- Richard Feynman
--
Kenneth
