On 23-06-22, 14:29, Rafael J. Wysocki wrote: > On Thu, Jun 23, 2022 at 10:10 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote: > > > > On 13-06-22, 20:35, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > > > Instead of walking the list of children of an ACPI device directly, > > > use acpi_dev_for_each_child() to carry out an action for all of > > > the given ACPI device's children. > > > > > > This will help to eliminate the children list head from struct > > > acpi_device as it is redundant and it is used in questionable ways > > > in some places (in particular, locking is needed for walking the > > > list pointed to it safely, but it is often missing). > > > > Applied, thanks > > Thanks, but the export of acpi_dev_for_each_child() is being added by > one of the previous patches in the series, so this one will not > compile without the rest of the series in the modular case. Aha, I checked the symbol exists and my test build passed! > > Is this not a problem? Yes indeed, so can you give a tag for that and or would you like to taje this thru ACPI tree, in that case Acked-By: Vinod Koul <vkoul@xxxxxxxxxx> BR -- ~Vinod
