pon., 20 cze 2022 o 19:59 Andrew Lunn <andrew@xxxxxxx> napisał(a): > > On Mon, Jun 20, 2022 at 05:02:14PM +0200, Marcin Wojtas wrote: > > This patch allows to use fixed_phy driver and its helper > > functions without Device Tree dependency, by swtiching from > > of_ to fwnode_ API. > > Do you actually need this? phylink does not use this code, it has its > own fixed link implementation. And that implementation is not limited > to 1G. > Yes, phylink has its own fixed-link handling, however the net/dsa/port.c relies on fixed_phy helpers these are not 1:1 equivalents. I assumed this migration (fixed_phy -> phylink) is not straightforward and IMO should be handled separately. Do you recall justification for not using phylink in this part of net/dsa/*? Thanks, Marcin
