From: Bill Wendling <isanbard@xxxxxxxxx>
When compiling with -Wformat, clang emits the following warnings:
sound/core/control.c:2062:24: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
return request_module(module_name);
^~~~~~~~~~~
Use a string literal for the format string.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <isanbard@xxxxxxxxx>
---
sound/core/control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/control.c b/sound/core/control.c
index a25c0d64d104..a1778137147d 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -2059,7 +2059,7 @@ int snd_ctl_request_layer(const char *module_name)
up_read(&snd_ctl_layer_rwsem);
if (lops)
return 0;
- return request_module(module_name);
+ return request_module("%s", module_name);
}
EXPORT_SYMBOL_GPL(snd_ctl_request_layer);
--
2.36.1.255.ge46751e96f-goog
