From: Bill Wendling <isanbard@xxxxxxxxx>
When compiling with -Wformat, clang emits the following warnings:
fs/quota/dquot.c:206:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
request_module(module_names[qm].qm_mod_name))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Use a string literal for the format string.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <isanbard@xxxxxxxxx>
---
fs/quota/dquot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index a74aef99bd3d..3b613de3b371 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -203,7 +203,7 @@ static struct quota_format_type *find_quota_format(int id)
module_names[qm].qm_fmt_id != id; qm++)
;
if (!module_names[qm].qm_fmt_id ||
- request_module(module_names[qm].qm_mod_name))
+ request_module("%s", module_names[qm].qm_mod_name))
return NULL;
spin_lock(&dq_list_lock);
--
2.36.1.255.ge46751e96f-goog
