On 6/9/22 12:35, Rafael J. Wysocki wrote: > On Thu, Jun 9, 2022 at 6:21 PM Pierre-Louis Bossart > <pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote: >> >> >>>> Shouldn't the return of sdw_acpi_find_one() be trapped, e.g. with >>>> >>>> return acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus); >>> >>> Sure, I'll do that. Thanks! >> >> I also added this EXPORT_SYMBOL to work-around link errors, not sure if >> this is in your tree already? > > One of the previous patches in the series is adding the export. ok. I ran a bunch of tests with those two changes, so feel free to take my tags: Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>