On Thu, Jun 9, 2022 at 5:29 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, Jun 09, 2022 at 03:58:24PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > Instead of walking the list of children of an ACPI device directly, > > use acpi_dev_for_each_child() to carry out an action for all of > > the given ACPI device's children. > > ... > > > + return acpi_dev_for_each_child(ACPI_COMPANION(&cdev->dev), > > + check_offline, NULL); > > I would find this on one line better and not missing important details after > 80th character. I see that you've made similar comments on a few other patches. I'll change all of them to be one line (longer that 80 chars), but OTOH there are people who still don't like that.
