Re: [PATCH v3 2/8] ACPI: property: Tie data nodes to acpi handles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafael,

On Thu, May 26, 2022 at 09:19:17PM +0200, Rafael J. Wysocki wrote:
> > +static int acpi_tie_nondev_subnodes(struct acpi_device_data *data)
> > +{
> > +       struct acpi_data_node *dn;
> > +
> > +       list_for_each_entry(dn, &data->subnodes, sibling) {
> > +               acpi_status status;
> > +               int ret;
> > +
> > +               status = acpi_attach_data(dn->handle, acpi_nondev_subnode_tag, dn);
> > +               if (ACPI_FAILURE(status)) {
> > +                       acpi_handle_err(dn->handle, "Can't tag data node\n");
> > +                       return 0;
> > +               }
> > +
> > +               ret = acpi_tie_nondev_subnodes(&dn->data);
> > +               if (ret)
> > +                       return ret;
> 
> Is it actually possible that this returns anything different from 0?

acpi_attach_data() involves allocating memory and resolving a reference.
Both can fail.

-- 
Regards,

Sakari Ailus



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux