Hi Bjorn, On 5/19/22 16:49, Bjorn Helgaas wrote: > On Thu, May 19, 2022 at 04:29:43PM +0200, Hans de Goede wrote: >> Hi, >> >> On 5/19/22 16:14, Bjorn Helgaas wrote: >>> On Thu, May 19, 2022 at 04:01:48PM +0200, Hans de Goede wrote: >>> >>>> Ok, I'll go and prepare a v9 and I will submit that later today. >>> >>> Would it be practical to split into three patches? >>> >>> 1) Add command-line args >>> 2) Add DMI quirks >>> 3) Add date check >>> >>> It seems easier to assimilate and document in smaller pieces, if >>> that's possible. >> >> Ack, will do. Note this will cause quite a bit of copy/paste >> in the commit msg to explain why these changes are necessary. > > OK, if the repetition gets excessive I can squash them back > together. Hopefully the main explanation can go in the first patch, > the second can just mention the fact that these machines need the > exception, and the third can focus on the plan for the future. I'm almost done with prepping v9 and atm there is a 17 line introduction of the problem which is shared between all 3 patches in the commit msg. I personally don't think this is too bad, but feel free to shorten it a bit in patch 2 + 3 before merging these. I think the split makes sense, so I would prefer you amending the commit msg over squashing them back together again. Regards, Hans
