Re: [PATCH 6/6] nvdimm/region: Delete nd_blk_region infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 09, 2022 at 07:49:48PM -0800, Dan Williams wrote:
> Now that the nd_namespace_blk infrastructure is removed, delete all the
> region machinery to coordinate provisioning aliased capacity between
> PMEM and BLK.

> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -189,7 +189,6 @@ static inline const char *nvdimm_cmd_name(unsigned cmd)
>  #define ND_DEVICE_REGION_BLK 3      /* nd_region: (parent of BLK namespaces) */
>  #define ND_DEVICE_NAMESPACE_IO 4    /* legacy persistent memory */
>  #define ND_DEVICE_NAMESPACE_PMEM 5  /* PMEM namespace (may alias with BLK) */
> -#define ND_DEVICE_NAMESPACE_BLK 6   /* BLK namespace (may alias with PMEM) */

As [1] suggests, this would break compilation of at least one Debian
package, as well as unknown number of any other potential users of this part
of UAPI.

>  #define ND_DEVICE_DAX_PMEM 7        /* Device DAX interface to pmem */
>  
>  enum nd_driver_flags {
> @@ -198,7 +197,6 @@ enum nd_driver_flags {
>  	ND_DRIVER_REGION_BLK      = 1 << ND_DEVICE_REGION_BLK,
>  	ND_DRIVER_NAMESPACE_IO    = 1 << ND_DEVICE_NAMESPACE_IO,
>  	ND_DRIVER_NAMESPACE_PMEM  = 1 << ND_DEVICE_NAMESPACE_PMEM,
> -	ND_DRIVER_NAMESPACE_BLK   = 1 << ND_DEVICE_NAMESPACE_BLK,

The same probably applies here.

[1] https://sources.debian.org/src/ipmctl/03.00.00.0429-1/src/os/linux/lnx_system.c/?hl=334#L334




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux