Hi, On 4/27/22 7:22 PM, Hans de Goede wrote: > On 4/22/22 16:47, Muhammad Usama Anjum wrote: >> Hi Hans, >> >> Can I add you as a maintainer of drivers/platform/x86/chromeos_acpi.c? >> You already maintain some other drivers in this directory. > If you want to rely on me as default/fallback maintainer > for the new chromeos_acpi driver, then simply don't add > a MAINTAINERS entry for this driver. > > I'm the default maintainer for everything under > drivers/platform/x86/ . > > With that said: > > >> On 4/18/22 10:57 PM, Muhammad Usama Anjum wrote: >>> Hi Benson, >>> >>> We are very near to getting this patch in. I can see that you are >>> maintaining Chrome Platform support. This driver is in >>> drivers/platform/x86/chromeos_acpi.c. Can you maintain this driver as >>> well? I'll add you to the maintainers. > now that you mention it, moving this to drivers/platform/chrome/ > actually seems like the most sensible thing to do given that > this is chrome specific platform code. So please move it > there for the next version. > This driver was added in platform/x86 as it is only x86 specific. Definitely it makes more sense to move it to platform/chrome. I'll move it. > Talking about the next version, please address all review > remarks from Barnabás for the next version. > After Greg's comment to define attributes at compile time, the driver will change completely and way simpler. > Regards, > > Hans > > > -- Muhammad Usama Anjum
