This caught my eye when I saw it was def_bool and hence largely pointless to have a Kconfig for it at all. Yet there is no reason why you shouldn't be able to opt out of Atom platform support if you only care about desktop and server class CPUs. It was introduced as def_bool, but there is no obvious reason as to why it was forcibly built-in for everyone, other than LPSS implicitly relying on it (which is now fixed). So here we fix up the Kconfig and open the door for people to opt out. Since putting "default y" on anything that isn't absolutely essential is generally frowned upon, I made the default be CONFIG_MATOM. People who use "make oldconfig" or similar won't notice any difference. The two "unchanged" lines for PCI and COMMON_CLK appear in the diff from fixing a whitespace issue that somehow managed to live on despite being moved between two different Kconfig files since its introduction. Cc: Aubrey Li <aubrey.li@xxxxxxxxxxxxxxx> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Cc: Hans de Goede <hdegoede@xxxxxxxxxx> Cc: Mark Gross <markgross@xxxxxxxxxx> Cc: platform-driver-x86@xxxxxxxxxxxxxxx Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- drivers/platform/x86/Kconfig | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index f08ad85683cb..86459e99d831 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1163,6 +1163,11 @@ config WINMATE_FM07_KEYS endif # X86_PLATFORM_DEVICES config PMC_ATOM - def_bool y - depends on PCI - select COMMON_CLK + bool "Intel Atom SOC Power Management Controller driver" + default MATOM + depends on PCI + select COMMON_CLK + help + This enables support for the Atom SOC Power Management Controller + driver, and associated platform clocks. If you intend to boot this + kernel on platforms with an intel Atom CPU, say Y here. -- 2.17.1
