On Thu, Apr 21, 2022 at 6:43 PM Tom Rix <trix@xxxxxxxxxx> wrote:
>
> Smatch reports this repesentative issue
> bgrt.c:26:1: warning: symbol 'bgrt_attr_version' was not declared. Should it be static?
> Similar for *status,type,xoffset,yoffset
>
> These variables are defined with the BGRT_SHOW macro.
> For the definition of bgrt_attr_##_name,
> the storage-class specifier should be static
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
> drivers/acpi/bgrt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/bgrt.c b/drivers/acpi/bgrt.c
> index 02d208732f9a..e4fb9e225ddf 100644
> --- a/drivers/acpi/bgrt.c
> +++ b/drivers/acpi/bgrt.c
> @@ -21,7 +21,7 @@ static struct kobject *bgrt_kobj;
> { \
> return sysfs_emit(buf, "%d\n", bgrt_tab._member); \
> } \
> - struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name)
> + static struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name)
>
> BGRT_SHOW(version, version);
> BGRT_SHOW(status, status);
> --
Applied as 5.19 material, thanks!
