On Wed, Apr 20, 2022 at 05:48:28PM +0100, Shameer Kolothum wrote: > @@ -141,6 +149,11 @@ struct iommu_resv_region { > size_t length; > int prot; > enum iommu_resv_type type; > + union { > + struct iommu_iort_rmr_data rmr; > + } fw_data; > + void (*resv_region_free_fw_data)(struct device *dev, > + struct iommu_resv_region *region); I'd shorten the name to just free. Also any reason the call to this method isn't also added in this patch as it logically belongs here?