Re: [PATCH v9 00/11] ACPI/IORT: Support for IORT RMR node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shameer,

On 4/4/2022 3:41 PM, Shameer Kolothum wrote:
Hi

v8 --> v9
  - Adressed comments from Robin on interfaces as discussed here[0].
  - Addressed comments from Lorenzo.
Though functionally there aren't any major changes, the interfaces have
changed from v8 and for that reason not included the T-by tags from
Steve and Eric yet(Many thanks for that). Appreciate it if you could
give this a spin and let me know.

(The revised ACPICA pull request for IORT E.d related changes is
here[1] and this is now merged to acpica:master.)

Please take a look and let me know your thoughts.

Thanks,
Shameer
[0] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-arm-kernel%2Fc982f1d7-c565-769a-abae-79c962969d88%40arm.com%2F&data=04%7C01%7Claurentiu.tudor%40nxp.com%7C2c1805513e0c4509194608da1638a306%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637846729754056888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=R2Rw4JK1ugTN1QA4umzMuLVem2oS9BZucbvNoZqSJ3I%3D&reserved=0
[1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Facpica%2Facpica%2Fpull%2F765&data=04%7C01%7Claurentiu.tudor%40nxp.com%7C2c1805513e0c4509194608da1638a306%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637846729754056888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=0aC%2BwZXPL4b0ZWIXw3TGwFE3NqPUMVJ3IbpsxeQF8zw%3D&reserved=0

 From old:
We have faced issues with 3408iMR RAID controller cards which
fail to boot when SMMU is enabled. This is because these
controllers make use of host memory for various caching related
purposes and when SMMU is enabled the iMR firmware fails to
access these memory regions as there is no mapping for them.
IORT RMR provides a way for UEFI to describe and report these
memory regions so that the kernel can make a unity mapping for
these in SMMU.

Change History:

v7 --> v8
   - Patch #1 has temp definitions for RMR related changes till
     the ACPICA header changes are part of kernel.
   - No early parsing of RMR node info and is only parsed at the
     time of use.
   - Changes to the RMR get/put API format compared to the
     previous version.
   - Support for RMR descriptor shared by multiple stream IDs.

v6 --> v7
  -fix pointed out by Steve to the SMMUv2 SMR bypass install in patch #8.

v5 --> v6
- Addressed comments from Robin & Lorenzo.
   : Moved iort_parse_rmr() to acpi_iort_init() from
     iort_init_platform_devices().
   : Removed use of struct iort_rmr_entry during the initial
     parse. Using struct iommu_resv_region instead.
   : Report RMR address alignment and overlap errors, but continue.
   : Reworked arm_smmu_init_bypass_stes() (patch # 6).
- Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8).
- Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based
   on Type of RMR region. Suggested by Jon N.

v4 --> v5
  -Added a fw_data union to struct iommu_resv_region and removed
   struct iommu_rmr (Based on comments from Joerg/Robin).
  -Added iommu_put_rmrs() to release mem.
  -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by
   yet because of the above changes.

v3 -->v4
-Included the SMMUv2 SMR bypass install changes suggested by
  Steve(patch #7)
-As per Robin's comments, RMR reserve implementation is now
  more generic  (patch #8) and dropped v3 patches 8 and 10.
-Rebase to 5.13-rc1

RFC v2 --> v3
  -Dropped RFC tag as the ACPICA header changes are now ready to be
   part of 5.13[0]. But this series still has a dependency on that patch.
  -Added IORT E.b related changes(node flags, _DSM function 5 checks for
   PCIe).
  -Changed RMR to stream id mapping from M:N to M:1 as per the spec and
   discussion here[1].
  -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!)

Jon Nettleton (1):
   iommu/arm-smmu: Get associated RMR info and install bypass SMR

Shameer Kolothum (10):
   ACPI/IORT: Add temporary RMR node flag definitions
   iommu: Introduce a union to struct iommu_resv_region
   ACPI/IORT: Make iort_iommu_msi_get_resv_regions() return void
   ACPI/IORT: Provide a generic helper to retrieve reserve regions
   iommu/dma: Introduce a helper to remove reserved regions
   ACPI/IORT: Add support to retrieve IORT RMR reserved regions
   ACPI/IORT: Add a helper to retrieve RMR info directly
   iommu/arm-smmu-v3: Introduce strtab init helper
   iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force
     bypass
   iommu/arm-smmu-v3: Get associated RMR info and install bypass STE

  drivers/acpi/arm64/iort.c                   | 369 ++++++++++++++++++--
  drivers/iommu/apple-dart.c                  |   2 +-
  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |  80 ++++-
  drivers/iommu/arm/arm-smmu/arm-smmu.c       |  54 ++-
  drivers/iommu/dma-iommu.c                   |  11 +-
  drivers/iommu/virtio-iommu.c                |   2 +-
  include/linux/acpi_iort.h                   |  18 +-
  include/linux/dma-iommu.h                   |   5 +
  include/linux/iommu.h                       |   9 +
  9 files changed, 505 insertions(+), 45 deletions(-)


I've tested the patches on a NXP LX2160A with SMMUv2 and things look fine. Thanks!

Tested-by: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>

---
Best Regards, Laurentiu



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux