> +static void iort_rmr_desc_check_overlap(struct acpi_iort_rmr_desc *desc, u32 count) Overly long line. > void iommu_dma_put_resv_regions(struct device *dev, struct list_head *list) > { > + if (!is_of_node(dev_iommu_fwspec_get(dev)->iommu_fwnode)) > + iort_iommu_put_resv_regions(dev, list); > + > generic_iommu_put_resv_regions(dev, list); > } Why can't this just go into generic_iommu_put_resv_regions? The idea that the iommu low-level drivers need to call into dma-iommu which is a consumer of the IOMMU API is odd. Especially if that just calls out to ACPI code and generic IOMMU code only anyway.