drivers/acpi/processor_throttling.c:990: warning: 'ret' may be used
uninitialized in this function
-Len
I will eliminate the warning message and refresh the patch.
Thanks.
> + for_each_cpu_mask(i, online_throttling_cpus) {
> + t_state.cpu = i;
> + acpi_processor_throttling_notifier(THROTTLING_PRECHANGE,
> + &t_state);
> + }
> + /*
> + * The function of acpi_processor_set_throttling will be called
> + * to switch T-state. If the coordination type is SW_ALL or
HW_ALL,
> + * it is necessary to call it for every affected cpu. Otherwise
> + * it can be called only for the cpu pointed by pr.
> + */
> + if (p_throttling->shared_type == DOMAIN_COORD_TYPE_SW_ANY) {
> + set_cpus_allowed(current, cpumask_of_cpu(pr->id));
> + ret = p_throttling->acpi_processor_set_throttling(pr,
> + t_state.target_state);
> + } else {
> + /*
> + * When the T-state coordination is SW_ALL or HW_ALL,
> + * it is necessary to set T-state for every affected
> + * cpus.
> + */
> + for_each_cpu_mask(i, online_throttling_cpus) {
> + match_pr = processors[i];
> + /*
> + * If the pointer is invalid, we will report the
> + * error message and continue.
> + */
> + if (!match_pr) {
> + ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> + "Invalid Pointer for CPU %d\n",
i));
> + continue;
> + }
> + /*
> + * If the throttling control is unsupported on
CPU i,
> + * we will report the error message and
continue.
> + */
> + if (!match_pr->flags.throttling) {
> + ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> + "Throttling Controll is
unsupported "
> + "on CPU %d\n", i));
> + continue;
> + }
> + t_state.cpu = i;
> + set_cpus_allowed(current, cpumask_of_cpu(i));
> + ret = match_pr->throttling.
> + acpi_processor_set_throttling(
> + match_pr, t_state.target_state);
> + }
> + }
> + /*
> + * After the set_throttling is called, the
> + * throttling notifier is called for every
> + * affected cpu to update the T-states.
> + * The notifier event is THROTTLING_POSTCHANGE
> + */
> + for_each_cpu_mask(i, online_throttling_cpus) {
> + t_state.cpu = i;
> +
acpi_processor_throttling_notifier(THROTTLING_POSTCHANGE,
> + &t_state);
> + }
> /* restore the previous state */
> set_cpus_allowed(current, saved_mask);
> return ret;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi"
in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
