On Thu, Mar 17, 2022 at 11:11:21AM -0700, Nick Desaulniers wrote:
> On Thu, Mar 17, 2022 at 2:07 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Wed, Mar 16, 2022 at 02:30:55PM -0700, Bill Wendling wrote:
> > NAK.
I hope you read my follow up to this.
> Andy,
> Our goal is to enable -Wformat for CC=clang. Please see also:
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
Not that I agree on that commit for %h[h]x
signed char ch = -1;
printf("%x\n", ch);
printf("%hhx\n", ch);
That's why my first reaction on this change was NAK.
> and the lore link it cites.
> https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@xxxxxxxxxxxxxx/
> (I saw your follow up; this patch is one of the less controversial
> ones though since the types are not ones that are promoted).
That said, I hope you are very well aware of the case.
--
With Best Regards,
Andy Shevchenko
