On Wed, Mar 9, 2022 at 2:48 PM Limonciello, Mario
<Mario.Limonciello@xxxxxxx> wrote:
>
> [AMD Official Use Only]
>
>
> > >
> > > commit a412caea5a2d ("ACPI: bus: Allow negotiating _OSC capabilities")
> > > added support for `acpi_run_osc` to return `AE_SUPPORT` when negotiating
> > > an _OSC.
> > >
> > > This was fixed in other kernel consumers, but `acpi_pci_run_osc` was
> > > missed. Update the function to detect when called with
> > `OSC_QUERY_ENABLE`
> > > set and attempt to negotiate up to 5 times.
> >
> > This is not how it is designed to work, though.
> >
> > acpi_pci_query_osc() is for that.
> >
> > >
> > > Reported-by: Qian Cai <quic_qiancai@xxxxxxxxxxx>
> > > Fixes: a412caea5a2d ("ACPI: bus: Allow negotiating _OSC capabilities")
> >
> > So I'm seriously thinking about dropping that whole lot at this point.
>
> Do you want me to send up a series perhaps that reverts those 3 commits
I can just drop them at this point, so no need to revert.
> and instead moves the logic changes on query handling from acpi_run_osc into
> acpi_bus_osc_negotiate_platform_control?
Yes, please!
