Le Wed, 23 Feb 2022 17:05:22 +0200, Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> a écrit : > > const void *device_get_match_data(struct device *dev) > > { > > if (!fwnode_has_op(fwnode, device_get_match_data) > > return fwnode_get_match_data(dev); > > return fwnode_call_ptr_op(dev_fwnode(dev),device_get_match_data, dev); > > } > > > > But I thought it was more convenient to do it by setting the > > .device_get_match_data field of software_node operations. > > Should this function be called e.g. software_node_get_match_data() instead, > as it seems to be specific to software nodes? Hi Sakari, You are right, since the only user of this function currently is the software_node operations, then I should rename it and move it to swnode.c maybe. -- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com