RE: Regression in 5.16-rc1 with suspend to idle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[AMD Official Use Only]

> 
> OK

https://lore.kernel.org/platform-driver-x86/20220221200728.2323469-1-mario.limonciello@xxxxxxx/T/#u

> 
> > Long term - are you opposed to drivers/acpi/x86/s2idle.c moving to
> drivers/platform/x86/?
> 
> It is tied to the code in sleep.c, so I'd rather not move it.

OK if we're keeping it there, would you be open to a patch exporting a symbol to
let other drivers register another callback after LPS0?  It's somewhat similar to what my
test hack did and might be a better long term solution if so.

> 
> > I'd really like the stuff amd-pmc does to be a callback after lps0 (which is closer
> to how it works
> > on Windows - it's the very last thing).
> 
> I see.
> 
> A notifier-based driver interface to be invoked from s2idle.c should
> work for that.
> 
> > I feel like keeping the stuff it does as noirq is generally fragile, and I want to
> avoid this kind
> > of breakage.
> 
> Sure.




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux