>-----Original Message----- >From: Kevin Hilman [mailto:khilman@xxxxxxxxxx] >Sent: Thursday, January 31, 2008 1:34 PM >To: Rafael J. Wysocki >Cc: Pallipadi, Venkatesh; Len Brown; ACPI Devel Maling List >Subject: Re: [linux-pm] [PATCH] CPUidle: compile fix for non-x86 > >[ Another update based on Rafael's suggestions. ] > >Convert cpu_idle_wait() to cpuidle_kick_cpus() macro which is >SMP-only, and gives error on non supported CPU. > >Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxx> > >diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >index 80b7ba4..a3e8ef4 100644 >--- a/arch/x86/Kconfig >+++ b/arch/x86/Kconfig >@@ -105,6 +105,9 @@ config ARCH_HAS_ILOG2_U32 > config ARCH_HAS_ILOG2_U64 > def_bool n > >+config ARCH_HAS_CPU_IDLE_WAIT >+ def_bool y >+ > config GENERIC_CALIBRATE_DELAY > def_bool y > >diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c >index d2fabe7..794962d 100644 >--- a/drivers/cpuidle/cpuidle.c >+++ b/drivers/cpuidle/cpuidle.c >@@ -82,7 +82,7 @@ void cpuidle_uninstall_idle_handler(void) > { > if (enabled_devices && (pm_idle != pm_idle_old)) { > pm_idle = pm_idle_old; >- cpu_idle_wait(); >+ cpuidle_kick_cpus(); > } > } > >diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h >index c4e0016..23f063a 100644 >--- a/include/linux/cpuidle.h >+++ b/include/linux/cpuidle.h >@@ -72,6 +72,19 @@ cpuidle_set_statedata(struct cpuidle_state >*state, void *data) > state->driver_data = data; > } > >+#ifdef CONFIG_SMP >+#ifdef ARCH_HAS_CPU_IDLE_WAIT You will have to do this one more time :-(. This has to be CONFIG_ARCH_HAS_CPU_IDLE_WAIT instead of ARCH_HAS_CPU_IDLE_WAIT here. Thanks, Venki - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
