Hi,
Just a few comments for now as I don't have much time until this weekend.
30/01/08 18:27, Thomas Renninger wrote/a écrit:
:
On Fri, 2008-01-25 at 23:39 -0500, Len Brown wrote:
:
Probably it is best to forward the original patch
w/ proper credits, and then send updates to address 1-4.
Thomas, the patch you have included is only the "original" patch, right?
We need to address the points 1-4 (which seem very reasonable) later on
with additional patches. I think most of them are already implemented in
http://gaugusch.at/acpi-dsdt-initrd-patches/acpi-dsdt-initrd-v0.8.2-2.6.17-ssdt.patch
So that should be quite easy :-)
I do not know who initially came up with this, I just modified/adjusted
the patch sometimes. I expect it's Markus, possibly Eric or best both
who should be mentioned as author.
Yep, to be precise, Markus Gaugusch is the original author, I'm just the
current maintainer, and Thomas has been very helpful for a looong time :-)
:
Jeff (Mahony) has adjusted the last bits of it when he updated it to the
latest rcX-gitY version:
Changes:
We no longer call populate_rootfs() twice. If we want the custom DSDT,
we load the rootfs before ACPI. Otherwise, it is loaded at the
appropriate
initcall time. -jeffm
I had left it this way because I though Linus had a good reason for
delaying populate_rootfs(). But if it works, fine! Maybe some additional
comments should be added in before the #ifdef's to clearly show that
populate_rootfs() is _always_ called, and they modify only the moment it
is called.
There is a new version at
http://gaugusch.at/acpi-dsdt-initrd-patches/acpi-dsdt-initrd-v0.8.4-2.6.21.patch,
but there doesn't seem to be any real changes other than elminating the
file
name array.
Yes, exactly.
In fact, I added the array some time ago.
Not sure whether the latest Version of Eric/Markus can also load several
DSDT/SSDTs? Maybe you found a more elegant way?
Nope. On the website (http://gaugusch.at/kernel.shtml) you can just find
two versions of the patch: one simple and one with your addition for
SSDTs support. At least with SSDTs support there is even an advantage
over the DSDT-in-kernel version :-)
Just one comment about the patch for now: it misses
Documentation/dsdt-initrd.txt . Please include this file too so that the
documentation is provided at the same time (it's in the official patch).
I'll test the patch and try to be productive this weekend.
See you,
Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
