On Mon, Jan 31, 2022 at 6:49 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes: > > On Mon, Jan 31, 2022 at 6:07 PM Hector Martin <marcan@xxxxxxxxx> wrote: ... > >> + if (!board_type) > >> + return NULL; > > > > I still think it's better to have both callers do the same thing. > > > > Now it will be the double check in one case, > > I already applied a similar patch: > > https://git.kernel.org/wireless/wireless/c/665408f4c3a5 "Similar" means that it took into account the concern I expressed here :-) I would have done slightly differently, but the main idea is the same. Thank you! -- With Best Regards, Andy Shevchenko
