Fri, Jan 21, 2022 at 2:50 PM Akhil R <akhilrajeev@xxxxxxxxxx> wrote:
> >
> > > > Added details and example for named interrupts in the ACPI table.
> > >
> > > Added details and example for --> Add a detailed example of the
> > >
> > > ...
> > >
> > > > + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
> > > > + 0x20,
> > >
> > > I would think of splitting this to two separate entries in between
> > > of which the
> > > GpioInt() resource is provided. It will explicitly show that you
> > > describe the case only for Interrupt(). Something like
> > >
> > > Interrupt (...) { 0x20 }
> > > GpioInt(...) { ... }
> > > Interrupt (...) { 0x24 }
> > >
> > > But it's up to you.
> > Instead, would it be good to add a statement mentioning this
> > explicitly. Something like -
> >
> > The interrupt name 'default' will correspond to 0x20 in Interrupt()
> > resource and 'alert' to 0x24. Note that only the Interrupt() resource
> > is mapped and not GpioInt() or similar.
> >
> > I feel mixing these in the example would add a bit of confusion to the reader.
>
> That's why I added "up to you" in my previous reply. I also thought about the
> example being a bit confusing for a reader who is non-familiar with the ACPI.
Thanks. Will send out an updated patch.
Thanks,
Akhil
