> On Wed, Jan 12, 2022 at 4:15 PM Akhil R <akhilrajeev@xxxxxxxxxx> wrote: > > > > Change of_*() functions to device_*() for firmware agnostic usage. > > This allows to have smbus_alert interrupt without any changes > > the smbus_alert > > > in the controller drivers using ACPI table. > > the ACPI > > ... > > This change reveals potential issue: > > > - irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert"); > > + irq = device_irq_get_byname(adapter->dev.parent, "smbus_alert"); > > > if (irq <= 0) > > I guess this '= 0' part should be fixed first. '0' is a failure as per the documentation of of_irq_get_byname() as well as of_irq_get(). The case is different for acpi_irq_get(), but it is handled in fwnode_irq_get(). If I understood it right, a return value of '0' should be considered a failure here. Thanks, Akhil
