Re: [PATCH 30/34] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hector Martin <marcan@xxxxxxxxx>
Subject: Re: [PATCH 30/34] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path
From: Linus Walleij <linus.walleij@xxxxxxxxxx>
Date: Sun, 2 Jan 2022 07:16:57 +0100
Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Arend van Spriel <aspriel@xxxxxxxxx>, Franky Lin <franky.lin@xxxxxxxxxxxx>, Hante Meuleman <hante.meuleman@xxxxxxxxxxxx>, Chi-hsien Lin <chi-hsien.lin@xxxxxxxxxxxx>, Wright Feng <wright.feng@xxxxxxxxxxxx>, Chung-hsien Hsu <chung-hsien.hsu@xxxxxxxxxxxx>, Sven Peter <sven@xxxxxxxxxxxxx>, Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx>, Mark Kettenis <kettenis@xxxxxxxxxxx>, Rafał Miłecki <zajec5@xxxxxxxxx>, Pieter-Paul Giesberts <pieter-paul.giesberts@xxxxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, "John W. Linville" <linville@xxxxxxxxxxxxx>, "Daniel (Deognyoun) Kim" <dekim@xxxxxxxxxxxx>, "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, brcm80211-dev-list.pdl@xxxxxxxxxxxx, SHA-cyfmac-dev-list@xxxxxxxxxxxx
In-reply-to: <20211226153624.162281-31-marcan@marcan.st>
References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-31-marcan@marcan.st>

On Sun, Dec 26, 2021 at 4:40 PM Hector Martin <marcan@xxxxxxxxx> wrote:

> This avoids leaking memory if brcmf_chip_get_raminfo fails. Note that
> the CLM blob is released in the device remove path.
>
> Fixes: 82f93cf46d60 ("brcmfmac: get chip's default RAM info during PCIe setup")
> Signed-off-by: Hector Martin <marcan@xxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij

References:
- [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms
  - From: Hector Martin
- [PATCH 30/34] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path
  - From: Hector Martin

Prev by Date: Re: [PATCH 29/34] brcmfmac: pcie: Read the console on init and shutdown
Next by Date: Re: [PATCH 31/34] brcmfmac: fwil: Constify iovar name arguments
Previous by thread: [PATCH 30/34] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path
Next by thread: [PATCH 29/34] brcmfmac: pcie: Read the console on init and shutdown
Index(es):
- Date
- Thread

[Index of Archives] [Linux IBM ACPI] [Linux Power Management] [Linux Kernel] [Linux Laptop] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]