On Thu, Dec 23, 2021 at 5:36 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi Thomas, > > On 12/22/21 22:20, Thomas Weißschuh wrote: > > The EC/ACPI firmware on Lenovo ThinkPads used to report a status > > of "Unknown" when the battery is between the charge start and > > charge stop thresholds. On Windows, it reports "Not Charging" > > so the quirk has been added to also report correctly. > > > > Now the "status" attribute returns "Not Charging" when the > > battery on ThinkPads is not physicaly charging. > > > > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> > > Thanks, patch looks good to me. > > As for the userspace issues in dealing with the > POWER_SUPPLY_STATUS_NOT_CHARGING status, those indeed > have long been fixed and this status is already returned > acpi//battery.c from the acpi_battery_handle_discharging() > function for a while no; and we have had no complaints > about that: > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Applied as 5.17 material, thanks!
