Re: [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 23 January 2008 21:55, Carlos Corbacho wrote:
> Why not just match on:
> 
> > +	.ident = "Acer",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> > +		},
> > +	},
> 
> for all Acer laptops?

hmmm, because I assumed that dmi_check_system()
would do an exact string compare with "!strcmp()".

I'm surprised to discover it uses strstr() and matches
substrings instead.  Is there logic behind that?

Certainly it makes using a single entry to match
a vendor problematic, as a short vendor string
could potentially be a substring of a different (unknown) vendor...

-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux