On Wed, Dec 15, 2021 at 2:08 PM Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> wrote: > > Hi Rafael, > > On Wed, Dec 15, 2021 at 12:43:48PM +0100, Rafael J. Wysocki wrote: > > One overall problem I see here is that it potentially stores a bunch > > of _PLD buffers that will never be used, which is a waste of memory. > > > > It may be better to make acpi_device_get_location() evaluate _PLD for > > the target device if it cannot be found in the list and either update > > one of the existing entries if the crc matches and return the pld data > > from there, or add a new item to the list and return its pld data. > > The primary goal of this series is actually to see the other devices > that share a fixed location with our device. It would be good to mention that in the changelog then. > The _PLD buffer cache > would be nice, but not necessary. We don't have to store the _PLD > buffer itself as part of the location structure at all if that's a > problem. It may be cached on the first invocation of acpi_device_get_location() too, but I'm not sure how much overhead would be avoided by doing that. I guess it would make most sense in the shared _PLD case. > I'll make the change. OK
