On Thu, Dec 02, 2021 at 04:32:33PM +0000, Anand Ashok Dumbre wrote: ... > > > +/** > > > + * struct ams - Driver data for xilinx-ams (1) > > > + * @base: physical base address of device > > > + * @ps_base: physical base address of PS device > > > + * @pl_base: physical base address of PL device > > > + * @clk: clocks associated with the device > > > + * @dev: pointer to device struct > > > + * @lock: to handle multiple user interaction > > > + * @intr_lock: to protect interrupt mask values > > > + * @alarm_mask: alarm configuration > > > + * @current_masked_alarm: currently masked due to alarm > > > + * @intr_mask: interrupt configuration > > > + * @ams_unmask_work: re-enables event once the event condition > > > +disappears > > > > > + * This structure contains necessary state for Sysmon driver to > > > + operate > > > > Shouldn't be this "state for Sysmon driver to operate" a summary above? > > I don't understand. (1) is not so informative, this one is better. > > > + */ -- With Best Regards, Andy Shevchenko
