Hi Andy, On Tue, Nov 30, 2021 at 06:05:29PM +0200, Andy Shevchenko wrote: > On Tue, Nov 30, 2021 at 05:32:50PM +0200, Sakari Ailus wrote: > > fwnode_graph_get_remote_node() is only used by the tegra-video driver. > > Convert it to use newer fwnode_graph_get_endpoint_by_id() and drop > > now-unused fwnode_graph_get_remote_node(). > > ... > > > - remote = fwnode_graph_get_remote_node(fwnode, chan->portnos[0], > > - 0); > > - if (!remote) > > + struct fwnode_handle *ep, *remote; > > + > > + ep = fwnode_graph_get_endpoint_by_id(fwnode, > > + chan->portnos[0], 0, 0); > > What makes you to move portnos to the next line? It's pretty much under 80. It is. But the endpoint, the following argument, is closely related to the port number. For that reason I'd prefer to keep it as-is. -- Sakari Ailus