On Sat, Nov 27, 2021 at 11:57 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 11/26/21 16:46, Andy Shevchenko wrote: > > On Fri, Nov 26, 2021 at 04:21:08PM +0100, Hans de Goede wrote: ... > >> + int (*lpat_raw_to_temp)(struct acpi_lpat_conversion_table *lpat_table, > >> + int raw); > > > > Can be on one line. > > I tried to stay within (or at least close too) 80 lines here as that is > still the recommended limit. The new 100 is more of a checkpatch only > change, not a change in the codingstyle docs. Yes I know that and IIRC in ACPI we have a bit relaxed rules (WRT line length) even before checkpatch has relaxed them. But as you pointed out below it's not worth of resending since it can be amended when applying. > With that said I'm fine with changing this. Rafael, feel free to > change this while merging. Or let me know if you want a v2. -- With Best Regards, Andy Shevchenko