Hi Andy, On Mon, Nov 22, 2021 at 01:26:12PM +0200, Andy Shevchenko wrote: > On Sun, Nov 21, 2021 at 11:17:29PM +0800, Chen Yu wrote: > > Introduce a user space tool to make use of the interface exposed by > > Platform Firmware Runtime Update and Telemetry drivers. The users > > can use this tool to do firmware code injection, driver update and > > to retrieve the telemetry data. > > Have you tried to build tools with `make O=/my/tmp/folder/for/kernel/build ...` > which previously has been used for kernel builds? > I was not aware of that and just had a try. It seems that there is an issue in tools/power/acpi that, only with the following patch appiled, the make O=xxx would work: diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config index 331f6d30f472..cd7106876a5f 100644 --- a/tools/power/acpi/Makefile.config +++ b/tools/power/acpi/Makefile.config @@ -69,6 +69,7 @@ KERNEL_INCLUDE := $(OUTPUT)include ACPICA_INCLUDE := $(srctree)/../../../drivers/acpi/acpica CFLAGS += -D_LINUX -I$(KERNEL_INCLUDE) -I$(ACPICA_INCLUDE) CFLAGS += $(WARNINGS) +MKDIR = mkdir ifeq ($(strip $(V)),false) QUIET=@ diff --git a/tools/power/acpi/Makefile.rules b/tools/power/acpi/Makefile.rules index 2a6c170b57cd..1d7616f5d0ae 100644 --- a/tools/power/acpi/Makefile.rules +++ b/tools/power/acpi/Makefile.rules @@ -21,6 +21,7 @@ $(KERNEL_INCLUDE): $(objdir)%.o: %.c $(KERNEL_INCLUDE) $(ECHO) " CC " $(subst $(OUTPUT),,$@) + $(QUIET) $(MKDIR) -p $(objdir) 2>/dev/null $(QUIET) $(CC) -c $(CFLAGS) -o $@ $< all: $(OUTPUT)$(TOOL) -- 2.25.1 Should above patch be a separate one or folded in [4/4]? thanks, Chenyu > -- > With Best Regards, > Andy Shevchenko > >
