Many Cherry Trail DSDTs have an extra INT33FF device with UID 5, the intel_pinctrl_get_soc_data() call will fail for this extra unknown UID, leading to the following error in dmesg: cherryview-pinctrl: probe of INT33FF:04 failed with error -61 Add a check for this extra UID and return -ENODEV for it to silence this false-positive error message. Cc: Yauhen Kharuzhy <jekhor@xxxxxxxxx> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> --- Changes in v2: - Add Mika's Acked-by --- drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index da68f8a849ab..487e343b68e1 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1686,6 +1686,10 @@ static int chv_pinctrl_probe(struct platform_device *pdev) acpi_status status; int i, ret, irq; + /* Cherry Trail DSDTs have an extra INT33FF device with UID 5, ignore */ + if (!strcmp(adev->pnp.unique_id, "5")) + return -ENODEV; + soc_data = intel_pinctrl_get_soc_data(pdev); if (IS_ERR(soc_data)) return PTR_ERR(soc_data); -- 2.31.1
