On Wed, Oct 27, 2021 at 7:17 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, Oct 27, 2021 at 06:59:06PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > Instead of evaluating _ADR in acpi_find_child_device(), use the > > observation that it has already been evaluated and the value returned > > by it has been stored in the pnp.type.bus_address field of the ACPI > > device object at hand. > > ... > > > + acpi_bus_address addr = acpi_device_adr(adev); > > int score; > > > > - status = acpi_evaluate_integer(adev->handle, METHOD_NAME__ADR, > > - NULL, &addr); > > - if (ACPI_FAILURE(status) || addr != address) > > + if (!adev->pnp.type.bus_address || addr != address) > > continue; > > I'm not sure I understand the new check, i.e. !adev->pnp.type.bus_address. See acpi_set_pnp_ids(). adev->pnp.bus_addres is the address value and adev->pnp.type.bus_address is a flag that is set to 1 when _ADR is valid. > IIUC _ADR == 0 is a valid value and children may have it like this. That's true. > I believe this change will break the working things (first comes to my mind > is drivers/mfd/intel_quark_i2c_gpio.c). I don't think so.
